-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub actions checks cdn #460
Conversation
a2b2443
to
9535e56
Compare
- Lock ubuntu version to 20.04 - Steps names to make it more explicit - Fix OTP
b51f945
to
e93a058
Compare
788813b
to
52568e7
Compare
3084b71
to
c0e547c
Compare
c0e547c
to
d0bd9c6
Compare
@dantswain @joshuawscott |
@Argonus This is amazing! The earliest version of Elixir we support is 1.6. If changing that makes this library easier to maintain then I'm totally in favor. I hate to ask this after all the work you put in, but it looks like there's a bunch of formatting changes here... would you mind making those on a separate PR to make it easier to understand what changed in order to support github actions? Thanks! |
Sure thing, I propose to let's make static checks work only for ~newst version of elixir (that will support 1.6 syntaxes) & run tests for 1.6, 1.10 & 1.13 & corresponding OTP. |
Sounds good!
… On Apr 29, 2022, at 6:22 AM, Piotr Rybarczyk ***@***.***> wrote:
Sure thing, I propose to let's make static checks work only for ~newst version of elixir (that will support 1.6 syntaxes) & run tests for 1.6, 1.10 & 1.13 & corresponding OTP.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
2732384
to
f8e37bb
Compare
Support multiple otp & elixir version for tests Support only newst version for static check. Handle backward compability in tests
f8e37bb
to
5a3b861
Compare
Versions added.
|
@dantswain Just a reminder ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for doing this and sorry for the delay. Just a couple questions in the comments.
No description provided.